TONPPAMF

The Official NPPAngband And NPPMoria Forum

You are not logged in.

Announcement

November 28, 2016 - NPPAngband forum has been migrated to a new host. SSL has been enabled so please use https:// if possible.

#1 2016-03-11 15:36:57

hydraa
Member
Registered: 2004-10-11
Posts: 421

Crash in rest menu

Found this one today.  Pressed capital E in the rest menu.  Actually it is pressing the shift (left) that cause the rest menu to crash.  Also Ctrl (left) crashed it

Starting C:\NPPAngband_QT-Jeff\NPPQT\NPPGAMES.exe...
ASSERT: "uint(i) < uint(size())" in file ..\..\Qt\5.5\mingw492_32\include\QtCore/qstring.h, line 851

This application has requested the Runtime to terminate it in an unusual way.
Please contact the application's support team for more information.
C:\NPPAngband_QT-Jeff\NPPQT\NPPGAMES.exe exited with code 255

...

several exits with code 03 after this

Last edited by hydraa (2016-03-11 15:39:12)

Offline

#2 2016-03-11 19:05:06

NPPAngband
NPPAngband Maintainer
Registered: 2004-07-01
Posts: 1,647
Website

Re: Crash in rest menu

Finally, an easy one to find & fix!

cmd_actions.cpp, line 2279 add these 2 lines.  The line below it was the crash.  If a key was not pressed, the game would try to read the first letter of a NULL string.


+// Otherwise, the isLetter check below would cause the game to crash if just a modifier was pressed
+if (!txt.length()) return;

if (txt.at(0).isLetter())
{

Offline

#3 2017-06-09 05:30:20

Rahn
Member
Registered: 2017-06-05
Posts: 1

Re: Crash in rest menu

Thanks for the fix!

Offline

Board footer

Powered by FluxBB